driver: espi_rts5912: Set STS0 only when input buffer has data #97090
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
albertofloyd,
JasonLin-RealTek,
jvasanth1 and
VenkatKotakonda
drivers/espi/espi_realtek_rts5912.c
Outdated
| promt0_reg->STS |= ACPI_STS_STS0; | ||
| } | ||
|
|
||
| evt.evt_data = (uint8_t)promt0_reg->IB; |
There was a problem hiding this comment.
wouldn't this IB data invalid if IBF is not set?
in that case shouldn't this data copy code moved under above if condition?
There was a problem hiding this comment.
Fixed. Thanks for reminding.
When using the eSPI peripheral channel for HOST_CMD, the STS0 bit indicates that EC is busy. To reflect this properly, STS0 should only be set when there is actual input data to process. This avoids falsely signaling a busy state when there is no data. Signed-off-by: Elmo Lan <[email protected]>
elmo9999
force-pushed
the
fix_unexpected_set_STS
branch
from
dca6201 to
9e04f99
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the eSPI peripheral channel for HOST_CMD, the STS0 bit indicates that EC is busy.
To reflect this properly,
STS0 should only be set when there is actual input data to process.
This avoids falsely signaling a busy state when there is no data.